#38 revert flag #93
Merged
#38 revert flag #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rename the project filename
|
@joshuaherrera Feel free to ping me once this is ready to review! |
|
@dominikbraun This is ready, I won't make anymore changes, unless requested. |
dominikbraun
requested changes
Jun 5, 2021
There was a problem hiding this comment.
Thanks for working on this, I like your implementation! It looks pretty good to me, I only requested an extremely nit-picky change to emphasize that the --revert flag always leads to an return without any other logic being executed. My other questions regard runtime performance.
Co-authored-by: Dominik Braun <mail@dominikbraun.io>
Co-authored-by: Dominik Braun <mail@dominikbraun.io>
Co-authored-by: Dominik Braun <mail@dominikbraun.io>
Co-authored-by: Dominik Braun <mail@dominikbraun.io>
dominikbraun
approved these changes
Jun 6, 2021
|
This PR is contained in release 0.8.0. |
It was a pleasure! I really enjoy the project layout you set forth in timetrace, it makes coding quite enjoyable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #38 .
Currently, I rely on the user input record / project key to fetch the correct record, since relying on the struct's Key field can cause the record / project to not be found as reported in issues #81 and #89 , though I don't think this will need to change when those issues are resolved.